Bug 134402 - [ARMv7] Skip one particularly expensive fastFree() alignment check.
Summary: [ARMv7] Skip one particularly expensive fastFree() alignment check.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-27 10:16 PDT by Andreas Kling
Modified: 2014-06-27 14:14 PDT (History)
11 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2014-06-27 10:20 PDT, Andreas Kling
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-06-27 10:16:21 PDT
__umodsi3 is lava hot on PLT!
Comment 1 Andreas Kling 2014-06-27 10:20:39 PDT
Created attachment 233993 [details]
Patch
Comment 2 Andreas Kling 2014-06-27 11:07:10 PDT
Committed r170536: <http://trac.webkit.org/changeset/170536>
Comment 3 Darin Adler 2014-06-27 14:14:44 PDT
Comment on attachment 233993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233993&action=review

> Source/WTF/wtf/FastMalloc.cpp:4171
> +#if !(CPU(ARM_THUMB2) && !CPU(APPLE_ARMV7S))

Really needs a why comment. Would be very mysterious to a future reader.