Bug 135313 - Web Inspector: Timelines performance is very slow, has many forced layouts
Summary: Web Inspector: Timelines performance is very slow, has many forced layouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 131651 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-25 18:58 PDT by Joseph Pecoraro
Modified: 2014-07-30 12:36 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (8.39 KB, patch)
2014-07-25 19:04 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (8.88 KB, patch)
2014-07-25 20:08 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-25 18:58:30 PDT
* SUMMARY
Working with the Timelines panel there are a lot of performance issues. There are many forced layouts, multi-second hangs, and it can be unresponsive to user actions.

* STEPS TO REPRODUCE - 1
1. Inspect apple.com
2. Start a timeline recording
3. Focus the search field in the top right of the page
4. Type "test string"
  => everything is slow during the recording
5. Stop recording
6. Select the Script or Layout timeline
  => hangs for a very long time
Comment 1 Radar WebKit Bug Importer 2014-07-25 18:59:04 PDT
<rdar://problem/17818693>
Comment 2 Joseph Pecoraro 2014-07-25 19:04:08 PDT
Created attachment 235555 [details]
[PATCH] Proposed Fix

This is meant to reduce the number of obviously unnecessary forced layouts.

I think there is still work to be done to improve the performance even more during a recording, but I think this is big step forward both during a recording and post-recording when using the timelines.
Comment 3 Simon Fraser (smfr) 2014-07-25 19:18:45 PDT
Comment on attachment 235555 [details]
[PATCH] Proposed Fix

Awesome!
Comment 4 Joseph Pecoraro 2014-07-25 19:22:56 PDT
Comment on attachment 235555 [details]
[PATCH] Proposed Fix

Ugh, some typos in the ChangeLog I want to fix before landing. Will wait for review.
Comment 5 Joseph Pecoraro 2014-07-25 20:08:10 PDT
Created attachment 235560 [details]
[PATCH] Proposed Fix

Better. It turns out showEmptyPlaceholder could also benefit from the early return if nothing changed. This is another huge win if the time range selection doesn't start at 0.0. Otherwise we would have hit the same forced layout loop calling this over and over. Note, the messages is always the same so maybe we can simplify this a bit more.
Comment 6 WebKit Commit Bot 2014-07-26 09:43:16 PDT
Comment on attachment 235560 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235560

Committed r171645: <http://trac.webkit.org/changeset/171645>
Comment 7 WebKit Commit Bot 2014-07-26 09:43:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Joseph Pecoraro 2014-07-30 12:36:39 PDT
*** Bug 131651 has been marked as a duplicate of this bug. ***