createTable(VM&) does nothing with the VM. We can remove the argument and get rid of some code.
Oh man, this is snowballing..
Created attachment 235759 [details] Patch
Attachment 235759 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSStorageCustom.cpp:67: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/JSTypedArrays.cpp:38: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:79: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 145 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 235759 [details] Patch r=me
Created attachment 235760 [details] Patch for landing With build system fixes for other ports..
Attachment 235760 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSStorageCustom.cpp:67: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/JSTypedArrays.cpp:38: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:79: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 235762 [details] Patch for landing With win buildfix.
Attachment 235762 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSStorageCustom.cpp:67: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/JSTypedArrays.cpp:38: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:79: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 148 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 235759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235759&action=review > Source/WebCore/ChangeLog:40 > + * bindings/js/DOMObjectHashTableMap.cpp: Removed. Looks like we need to remove this from the other build systems, not just Xcode project files.
Comment on attachment 235762 [details] Patch for landing Rejecting attachment 235762 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 235762, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: cess/Plugins/Netscape/JSNPMethod.cpp Hunk #1 FAILED at 43. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPMethod.cpp.rej patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp Hunk #1 FAILED at 55. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5635845524553728
Committed r171824: <http://trac.webkit.org/changeset/171824>
(In reply to comment #11) > Committed r171824: <http://trac.webkit.org/changeset/171824> FYI: It broke the Apple Windows build.
(In reply to comment #12) > (In reply to comment #11) > > Committed r171824: <http://trac.webkit.org/changeset/171824> > > FYI: It broke the Apple Windows build. The build is still broken, please fix it ASAP. 1>jsc.obj : error LNK2001: unresolved external symbol "struct JSC::HashTable const JSC::globalObjectTable" (?globalObjectTable@JSC@@3UHashTable@1@B) 1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\jsc.exe : fatal error LNK1120: 1 unresolved externals