Bug 135451 - PropertyName's internal string is always atomic.
Summary: PropertyName's internal string is always atomic.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-30 21:25 PDT by Andreas Kling
Modified: 2014-07-30 22:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.85 KB, patch)
2014-07-30 21:28 PDT, Andreas Kling 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-07-30 21:25:18 PDT 
We should exploit this more.
Comment 1 Andreas Kling 2014-07-30 21:28:39 PDT 
Created attachment 235805 [details]
Patch
Comment 2 Benjamin Poulain 2014-07-30 22:34:39 PDT 
Comment on attachment 235805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235805&action=review

> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:57
> -    AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
> +    AtomicStringImpl* atomicPropertyName = propertyName.publicName();
>      return atomicPropertyName && document->hasDocumentNamedItem(*atomicPropertyName);

Looks like another of those cases where we query a hash table multiple times to access a property from JavaScript :(
Comment 3 Andreas Kling 2014-07-30 22:38:54 PDT 
Committed r171838: <http://trac.webkit.org/changeset/171838>