Bug 135519 - Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero for no reason.
Summary: Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-01 14:42 PDT by Andreas Kling
Modified: 2014-08-01 16:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2014-08-01 14:43 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-08-01 14:42:36 PDT 
We shouldn't set this structure flag for DOM objects that don't even intercept getOwnPropertySlotByIndex.
Comment 1 Andreas Kling 2014-08-01 14:43:59 PDT 
Created attachment 235904 [details]
Patch
Comment 2 Geoffrey Garen 2014-08-01 15:24:35 PDT 
Comment on attachment 235904 [details]
Patch

r=me

Does this make a benchmark or some other test case faster?
Comment 3 Andreas Kling 2014-08-01 15:47:33 PDT 
(In reply to comment #2)
> (From update of attachment 235904 [details])
> r=me
> 
> Does this make a benchmark or some other test case faster?

None that I know of. We could make one.
Comment 4 WebKit Commit Bot 2014-08-01 16:21:03 PDT 
Comment on attachment 235904 [details]
Patch

Clearing flags on attachment: 235904

Committed r171956: <http://trac.webkit.org/changeset/171956>
Comment 5 WebKit Commit Bot 2014-08-01 16:21:08 PDT 
All reviewed patches have been landed.  Closing bug.