Bug 135782 - for-in optimization should also make sure the base matches the object being iterated
Summary: for-in optimization should also make sure the base matches the object being i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 135812
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-08 18:21 PDT by Mark Hahnenberg
Modified: 2014-08-18 18:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.22 KB, patch)
2014-08-08 18:23 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (8.33 KB, patch)
2014-08-08 23:00 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-08-08 18:21:22 PDT 
Fix on its way...
Comment 1 Mark Hahnenberg 2014-08-08 18:23:45 PDT 
Created attachment 236329 [details]
Patch
Comment 2 Mark Hahnenberg 2014-08-08 23:00:43 PDT 
Created attachment 236331 [details]
Patch
Comment 3 Geoffrey Garen 2014-08-11 11:25:48 PDT 
Comment on attachment 236331 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-08-11 12:00:04 PDT 
Comment on attachment 236331 [details]
Patch

Clearing flags on attachment: 236331

Committed r172401: <http://trac.webkit.org/changeset/172401>
Comment 5 WebKit Commit Bot 2014-08-11 12:00:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Mark Lam 2014-08-11 12:49:40 PDT 
Looks like this is not just a 32-bit issue: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7945
Comment 8 WebKit Commit Bot 2014-08-11 12:56:51 PDT 
Re-opened since this is blocked by bug 135812
Comment 9 Mark Lam 2014-08-11 13:17:10 PDT 
Looks like there's a bug in the test.  "for (var p in a) {" should be "for (var p in b) {".  Currently re-testing before re-landing.
Comment 10 Geoffrey Garen 2014-08-11 14:47:05 PDT 
<rdar://problem/17793974>
Comment 11 Geoffrey Garen 2014-08-11 14:47:19 PDT 
Sorry, ignore that Radar link.
Comment 12 Mark Lam 2014-08-11 15:01:09 PDT 
Patch re-landed in r172413: <http://trac.webkit.org/r172413>.
Comment 13 Filip Pizlo 2014-08-18 18:32:35 PDT 
This was a 50% regression on string-fasta.