Bug 136348 - Use JSString::toIdentifier() in more places.
Summary: Use JSString::toIdentifier() in more places.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2014-08-28 13:14 PDT by Andreas Kling
Modified: 2014-08-28 14:38 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.76 KB, patch)
2014-08-28 13:16 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-08-28 13:14:51 PDT
JSString::toIdentifier() avoids allocating a new StringImpl when serializing a rope string into an already-existing Identifier.
Comment 1 Andreas Kling 2014-08-28 13:16:05 PDT
Created attachment 237324 [details]
Patch
Comment 2 Geoffrey Garen 2014-08-28 13:50:29 PDT
Comment on attachment 237324 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-08-28 14:38:35 PDT
Comment on attachment 237324 [details]
Patch

Clearing flags on attachment: 237324

Committed r173082: <http://trac.webkit.org/changeset/173082>
Comment 4 WebKit Commit Bot 2014-08-28 14:38:38 PDT
All reviewed patches have been landed.  Closing bug.