Bug 136579 - Move CallFrame and Register inlines functions out of JSScope.h
Summary: Move CallFrame and Register inlines functions out of JSScope.h
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 136649
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-05 10:58 PDT by Mark Lam
Modified: 2014-09-08 17:17 PDT (History)
9 users (show)

See Also:

Attachments
the patch (25.93 KB, patch)
2014-09-05 11:06 PDT, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
patch 2: +WebCore build fixes. (38.04 KB, patch)
2014-09-05 22:25 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
patch 3: one more WebCore build fix (38.03 KB, patch)
2014-09-08 15:25 PDT, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-09-05 10:58:08 PDT 
This include fixing up some files to #include JSCInlines.h to pick up these inline functions.  I also added JSCellInlines.h to JSCInlines.h since it is included from many of the affected .cpp files.
Comment 1 Mark Lam 2014-09-05 11:06:22 PDT 
Created attachment 237700 [details]
the patch
Comment 2 Geoffrey Garen 2014-09-05 11:58:22 PDT 
Comment on attachment 237700 [details]
the patch

r=me
Comment 3 Mark Lam 2014-09-05 18:26:10 PDT 
Comment on attachment 237700 [details]
the patch

WebCore side needed a lot of work with #includes.  I’ll upload an updated patch with WebCore changes once I’m done rebuilding the world.
Comment 4 Mark Lam 2014-09-05 22:25:05 PDT 
Created attachment 237729 [details]
patch 2: +WebCore build fixes.
Comment 5 Mark Lam 2014-09-08 15:25:17 PDT 
Created attachment 237815 [details]
patch 3: one more WebCore build fix
Comment 6 Geoffrey Garen 2014-09-08 15:52:08 PDT 
Comment on attachment 237815 [details]
patch 3: one more WebCore build fix

r=me
Comment 7 Mark Lam 2014-09-08 16:00:08 PDT 
Thanks for the review.  Landed in r173402: <http://trac.webkit.org/r173402>.
Comment 8 WebKit Commit Bot 2014-09-08 17:17:07 PDT 
Re-opened since this is blocked by bug 136649