Bug 136586 - Add bots to Apple build/test queues
Summary: Add bots to Apple build/test queues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-05 14:35 PDT by Lucas Forschler
Modified: 2014-09-05 16:40 PDT (History)
2 users (show)

See Also:

Attachments
v1 patch to add 6 bots (4.97 KB, patch)
2014-09-05 14:36 PDT, Lucas Forschler 		dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff
v2, with a ChangeLog this time. (5.54 KB, patch)
2014-09-05 14:43 PDT, Lucas Forschler 		no flags Details | Formatted Diff | Diff
v3 with updated ChangeLog/bug title (5.42 KB, patch)
2014-09-05 14:51 PDT, Lucas Forschler 		dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff
v4, ftw? (5.43 KB, patch)
2014-09-05 15:05 PDT, Lucas Forschler 		dbates: review+
Details | Formatted Diff | Diff
one more (5.43 KB, patch)
2014-09-05 16:01 PDT, Lucas Forschler 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2014-09-05 14:35:31 PDT 
This should help out with build/test times.
Comment 1 Lucas Forschler 2014-09-05 14:36:18 PDT 
Created attachment 237710 [details]
v1 patch to add 6 bots
Comment 2 Daniel Bates 2014-09-05 14:38:23 PDT 
Comment on attachment 237710 [details]
v1 patch to add 6 bots

Looks sane to me.
Comment 3 Daniel Bates 2014-09-05 14:40:03 PDT 
Comment on attachment 237710 [details]
v1 patch to add 6 bots

cq-; Missing ChangeLog entry.
Comment 4 Daniel Bates 2014-09-05 14:42:59 PDT 
Comment on attachment 237710 [details]
v1 patch to add 6 bots

View in context: https://bugs.webkit.org/attachment.cgi?id=237710&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:17
> +                    { "name": "apple-mac-121", "platform": "mac-mountainlion"},
> +                    { "name": "apple-mac-122", "platform": "mac-mountainlion"},
> +                    { "name": "apple-mac-123", "platform": "mac-mountainlion"},

Please put these in sorted order.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:33
> +                    { "name": "apple-mac-124", "platform": "mac-mavericks" },
> +                    { "name": "apple-mac-125", "platform": "mac-mavericks" },
> +                    { "name": "apple-mac-126", "platform": "mac-mavericks" },

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71
> +                      "slavenames": ["apple-mini-204", "apple-mac-121"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:88
> +                      "slavenames": ["apple-mini-208", "apple-mac-122"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:92
> +                      "slavenames": ["apple-mini-209", "apple-mac-123"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:118
> +                      "slavenames": ["apple-mini-212", "apple-mac-124"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123
> +                      "slavenames": ["apple-mini-129", "apple-mac-125"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:127
> +                      "slavenames": ["apple-mini-130", "apple-mac-126"]

Ditto.
Comment 5 Lucas Forschler 2014-09-05 14:43:58 PDT 
Created attachment 237711 [details]
v2, with a ChangeLog this time.
Comment 6 Lucas Forschler 2014-09-05 14:51:59 PDT 
Created attachment 237712 [details]
v3 with updated ChangeLog/bug title
Comment 7 Daniel Bates 2014-09-05 14:59:41 PDT 
Comment on attachment 237712 [details]
v3 with updated ChangeLog/bug title

View in context: https://bugs.webkit.org/attachment.cgi?id=237712&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:6
> +                    { "name": "apple-mac-121", "platform": "mac-mountainlion"},
> +                    { "name": "apple-mac-122", "platform": "mac-mountainlion"},
> +                    { "name": "apple-mac-123", "platform": "mac-mountainlion"},

This is OK as-is. We are inconsistent in how we align the "platform" in each line. For instance, on line 16 <http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json?rev=170172#L16> we add space characters before "platform" such that its aligned with the "platform" in lines above and below it until the definition for the Windows bots. We should pick a style convention for writing these arrays of dictionaries and stick with it throughout this file.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71
> +                      "slavenames": ["apple-mini-204", "apple-mac-121"]

Can we swap the files in this array such that the string literals are in sorted order?

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:88
> +                      "slavenames": ["apple-mini-208", "apple-mac-122"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123
> +                      "slavenames": ["apple-mini-129", "apple-mac-125"]

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:127
> +                      "slavenames": ["apple-mini-130", "apple-mac-126"]

Ditto.
Comment 8 Daniel Bates 2014-09-05 15:01:31 PDT 
(In reply to comment #7)
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:71
> > +                      "slavenames": ["apple-mini-204", "apple-mac-121"]
> 
> Can we swap the files in this array such that the string literals are in sorted order?

*string literals
Comment 9 Lucas Forschler 2014-09-05 15:05:25 PDT 
Created attachment 237713 [details]
v4, ftw?
Comment 10 Daniel Bates 2014-09-05 15:23:12 PDT 
Comment on attachment 237713 [details]
v4, ftw?

View in context: https://bugs.webkit.org/attachment.cgi?id=237713&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:123
> +                      "slavenames": ["apple-mini-129", "apple-mac-125"]

Nit: Swap the order of the string literals such that they are in sorted order.
Comment 11 Lucas Forschler 2014-09-05 16:01:42 PDT 
Created attachment 237718 [details]
one more
Comment 12 Daniel Bates 2014-09-05 16:05:22 PDT 
Comment on attachment 237718 [details]
one more

Thank you Lucas for updating the patch. It looks beautiful.
Comment 13 WebKit Commit Bot 2014-09-05 16:40:34 PDT 
Comment on attachment 237718 [details]
one more

Clearing flags on attachment: 237718

Committed r173341: <http://trac.webkit.org/changeset/173341>
Comment 14 WebKit Commit Bot 2014-09-05 16:40:36 PDT 
All reviewed patches have been landed.  Closing bug.