Bug 137045 - DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains
Summary: DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-23 14:36 PDT by Mark Lam
Modified: 2014-09-23 15:29 PDT (History)
1 user (show)

See Also:


Attachments
the patch. (2.55 KB, patch)
2014-09-23 14:41 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-09-23 14:36:34 PDT
DebuggerCallFrame::invalidate() currently invalidates all DebuggerCallFrames in the debugger stack, but only invalidates the DebuggerScope chain of the top most frame.  We should also invalidate all the DebuggerScope chains of the other frames in the debugger stack.
Comment 1 Mark Lam 2014-09-23 14:41:30 PDT
Created attachment 238572 [details]
the patch.
Comment 2 Geoffrey Garen 2014-09-23 15:09:01 PDT
Comment on attachment 238572 [details]
the patch.

r=me
Comment 3 WebKit Commit Bot 2014-09-23 15:29:40 PDT
Comment on attachment 238572 [details]
the patch.

Clearing flags on attachment: 238572

Committed r173896: <http://trac.webkit.org/changeset/173896>
Comment 4 WebKit Commit Bot 2014-09-23 15:29:42 PDT
All reviewed patches have been landed.  Closing bug.