Bug 137544 - [Mac] Show repaint counters in tile coverage map.
Summary: [Mac] Show repaint counters in tile coverage map.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-08 17:39 PDT by Andreas Kling
Modified: 2014-10-08 23:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2014-10-08 17:40 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Screenshot (97.26 KB, image/png)
2014-10-08 17:42 PDT, Andreas Kling 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-10-08 17:39:55 PDT 
It would be neat if we could show the tile repaint counters inside the coverage map. I have a little patch.
Comment 1 Andreas Kling 2014-10-08 17:40:32 PDT 
Created attachment 239505 [details]
Patch
Comment 2 Andreas Kling 2014-10-08 17:42:40 PDT 
Created attachment 239506 [details]
Screenshot
Comment 3 Simon Fraser (smfr) 2014-10-08 17:48:06 PDT 
Comment on attachment 239505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239505&action=review

> Source/WebCore/platform/graphics/ca/TileController.cpp:98
> +    updateTileCoverageMap();

We should inline updateTileCoverageMap().
Comment 4 Andreas Kling 2014-10-08 22:48:22 PDT 
(In reply to comment #3)
> (From update of attachment 239505 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239505&action=review
> 
> > Source/WebCore/platform/graphics/ca/TileController.cpp:98
> > +    updateTileCoverageMap();
> 
> We should inline updateTileCoverageMap().

Sure, I'll do that separately since it'll balloon a bit due to header dependencies.
Comment 5 WebKit Commit Bot 2014-10-08 23:26:10 PDT 
Comment on attachment 239505 [details]
Patch

Clearing flags on attachment: 239505

Committed r174496: <http://trac.webkit.org/changeset/174496>
Comment 6 WebKit Commit Bot 2014-10-08 23:26:14 PDT 
All reviewed patches have been landed.  Closing bug.