Bug 137873 - MacroAssemblerX86Common.cpp should be built on Windows too
Summary: MacroAssemblerX86Common.cpp should be built on Windows too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 137807
  Show dependency tree / graph
 
Reported: 2014-10-20 03:43 PDT by Csaba Osztrogonác
Modified: 2014-10-20 10:03 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2014-10-20 03:43 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-10-20 03:43:28 PDT 
MacroAssemblerX86Common.cpp should be built on Windows too
Comment 1 Csaba Osztrogonác 2014-10-20 03:43:51 PDT 
Created attachment 240106 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-10-20 04:00:26 PDT 
The goal of this bug report to add MacroAssemblerX86Common.cpp properly 
to the Windows build system to fix the build in bug137807 .

I think ClInclude for this cpp was only a typo, when this file was
added to the trunk - http://trac.webkit.org/changeset/153162/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj

Additionally it was added to the filter file as ClCompile - http://trac.webkit.org/changeset/153162/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters
But it was changed back to ClInclude in http://trac.webkit.org/changeset/153343/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters
Comment 3 Brent Fulgham 2014-10-20 09:24:36 PDT 
Comment on attachment 240106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240106&action=review

Thanks for catching this. r=me.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:308
> +    <ClCompile Include="..\assembler\MacroAssemblerX86Common.cpp" />

This was definitely a mistake made by someone manually copying/pasting the project file.
Comment 4 WebKit Commit Bot 2014-10-20 10:03:20 PDT 
Comment on attachment 240106 [details]
Patch

Clearing flags on attachment: 240106

Committed r174887: <http://trac.webkit.org/changeset/174887>
Comment 5 WebKit Commit Bot 2014-10-20 10:03:24 PDT 
All reviewed patches have been landed.  Closing bug.