https://bugs.webkit.org/show_bug.cgi?id=137873 is likely a cut-and-paste error that manifested because we had ClCompile and ClInclude entries mixed up in the wrong ItemGroups. We should fix these so that ClCompile entries are in the ClCompile ItemGroup, and ClInclude entries in the ClInclude ItemGroup. This will help reduce the change of future cut-and-paste errors of this nature.
(In reply to comment #0) > https://bugs.webkit.org/show_bug.cgi?id=137873 is likely a cut-and-paste > error that manifested because we had ClCompile and ClInclude entries mixed > up in the wrong ItemGroups. We should fix these so that ClCompile entries > are in the ClCompile ItemGroup, and ClInclude entries in the ClInclude > ItemGroup. This will help reduce the change of future cut-and-paste errors > of this nature. This is a great idea. We should also extend the style checker to look for these kinds of things.
Created attachment 240130 [details] The patch. Here's the patch, but I'm still need to test this with an actual build before committing.
Comment on attachment 240130 [details] The patch. r=me if it builds
It builds. I'll land manually.
Thanks for the review. Landed in r174895: <http://trac.webkit.org/r174895>.