Bug 137969 - Do not include GraphicsContext3D.h when 3D_GRAPHICS is not used
Summary: Do not include GraphicsContext3D.h when 3D_GRAPHICS is not used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 137488
  Show dependency treegraph
 
Reported: 2014-10-22 11:09 PDT by Milan Crha
Modified: 2014-10-22 23:45 PDT (History)
6 users (show)

See Also:


Attachments
proposed wk patch (1.08 KB, patch)
2014-10-22 11:12 PDT, Milan Crha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Crha 2014-10-22 11:09:54 PDT
The GraphicsContext3D.h includes ShaderLang.h, which might not be always available during the build time, thus better to not include GraphicsContext3D.h when the 3D_GRAPHICS is not used.
Comment 1 Milan Crha 2014-10-22 11:12:56 PDT
Created attachment 240280 [details]
proposed wk patch
Comment 2 WebKit Commit Bot 2014-10-22 23:45:48 PDT
Comment on attachment 240280 [details]
proposed wk patch

Clearing flags on attachment: 240280

Committed r175088: <http://trac.webkit.org/changeset/175088>
Comment 3 WebKit Commit Bot 2014-10-22 23:45:54 PDT
All reviewed patches have been landed.  Closing bug.