Bug 138096 - Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren().
Summary: Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-27 10:46 PDT by Andreas Kling
Modified: 2014-10-27 13:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2014-10-27 10:47 PDT, Andreas Kling 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-10-27 10:46:22 PDT 
Small patch inc.
Comment 1 Andreas Kling 2014-10-27 10:47:34 PDT 
Created attachment 240487 [details]
Patch
Comment 2 Chris Dumez 2014-10-27 10:48:48 PDT 
Comment on attachment 240487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240487&action=review

r=me with nit.

> Source/WebCore/rendering/RenderBox.cpp:2702
>          if (h.isAuto() && parent()->isDeprecatedFlexibleBox() && parent()->style().boxOrient() == HORIZONTAL

nit: is<RenderDeprecatedFlexibleBox>(*parent())
Comment 3 WebKit Commit Bot 2014-10-27 10:50:22 PDT 
Attachment 240487 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBox.cpp:2703:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2014-10-27 13:42:43 PDT 
Committed r175230: <http://trac.webkit.org/changeset/175230>