Bug 138119 - Simplified some JSObject methods for converting arrays to ArrayStorage shape
Summary: Simplified some JSObject methods for converting arrays to ArrayStorage shape
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-27 19:41 PDT by Mark Lam
Modified: 2014-10-27 22:05 PDT (History)
7 users (show)

See Also:

Attachments
the patch. (8.29 KB, patch)
2014-10-27 19:48 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-10-27 19:41:51 PDT 
Currently, for each Undecided, Int32, Double, and Contiguous array shapes, there are 3 JSObject methods to convert them to ArrayStorage shape:
    ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition, unsigned neededLength);
    ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition);
    ArrayStorage* convert<shape>ToArrayStorage(VM&);

However, the neededLength that is passed is always m_butterfly->vectorLength().  Hence, the method that takes a neededLength is really not needed.
Comment 1 Mark Lam 2014-10-27 19:48:21 PDT 
Created attachment 240522 [details]
the patch.
Comment 2 WebKit Commit Bot 2014-10-27 22:04:56 PDT 
Comment on attachment 240522 [details]
the patch.

Clearing flags on attachment: 240522

Committed r175240: <http://trac.webkit.org/changeset/175240>
Comment 3 WebKit Commit Bot 2014-10-27 22:05:00 PDT 
All reviewed patches have been landed.  Closing bug.