Bug 138352 - RenderQuote shouldn't need a pre-destructor hook.
Summary: RenderQuote shouldn't need a pre-destructor hook.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 22:36 PST by Andreas Kling
Modified: 2014-11-04 02:05 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2014-11-03 22:39 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-03 22:36:58 PST
RenderQuote got a willBeDestroyed() hook back when it wasn't always safe to access the RenderView from a RenderObject's destructor.

Since that's completely kool now, we should move that logic to the regular destructor instead.
Comment 1 Andreas Kling 2014-11-03 22:39:10 PST
Created attachment 240913 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-04 02:05:36 PST
Comment on attachment 240913 [details]
Patch

Clearing flags on attachment: 240913

Committed r175528: <http://trac.webkit.org/changeset/175528>
Comment 3 WebKit Commit Bot 2014-11-04 02:05:39 PST
All reviewed patches have been landed.  Closing bug.