Bug 138661 - Rename USE(MASM_PROBE) to ENABLE(MASM_PROBE)
Summary: Rename USE(MASM_PROBE) to ENABLE(MASM_PROBE)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 138660
  Show dependency tree / graph
 
Reported: 2014-11-12 09:25 PST by Mark Lam
Modified: 2014-11-14 12:28 PST (History)
3 users (show)

See Also:

Attachments
the patch. (17.93 KB, patch)
2014-11-12 09:36 PST, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-11-12 09:25:26 PST 
Also move the switch for enabling the use of MASM_PROBE from JavaScriptCore config.h to WTF's Platform.h.  This ensures that the setting is consistently applied even when building WebCore parts as well.

This is a step towards refactoring the probe mechanism to add printing functionality in JITted code for debugging
Comment 1 Mark Lam 2014-11-12 09:36:34 PST 
Created attachment 241430 [details]
the patch.
Comment 2 Michael Saboff 2014-11-12 10:12:12 PST 
Comment on attachment 241430 [details]
the patch.

r=me
Comment 3 Mark Lam 2014-11-12 12:11:40 PST 
Thanks for the review.  Landed in r176031: <http://trac.webkit.org/r176031>.