Bug 138880 - Move pseudo-style code from RenderObject to RenderElement.
Summary: Move pseudo-style code from RenderObject to RenderElement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-19 13:24 PST by Andreas Kling
Modified: 2014-11-19 16:17 PST (History)
11 users (show)

See Also:

Attachments
Patch (22.75 KB, patch)
2014-11-19 13:25 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-19 13:24:13 PST 
RenderText doesn't have style, so we should really move pseudo style code from RenderObject to RenderElement, too.
Comment 1 Andreas Kling 2014-11-19 13:25:40 PST 
Created attachment 241881 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-19 13:28:00 PST 
Attachment 241881 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderElement.h:50:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2014-11-19 15:30:47 PST 
Comment on attachment 241881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241881&action=review

> Source/WebCore/rendering/RenderElement.cpp:1419
> +RenderStyle* RenderElement::getCachedPseudoStyle(PseudoId pseudo, RenderStyle* parentStyle) const

get* naming here is not consistent with the current style, would be nice to fix that too at some point.
Comment 4 WebKit Commit Bot 2014-11-19 16:17:37 PST 
Comment on attachment 241881 [details]
Patch

Clearing flags on attachment: 241881

Committed r176365: <http://trac.webkit.org/changeset/176365>
Comment 5 WebKit Commit Bot 2014-11-19 16:17:42 PST 
All reviewed patches have been landed.  Closing bug.