Bug 138912 - Caret renderer is always a RenderBlock.
Summary: Caret renderer is always a RenderBlock.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-19 21:11 PST by Andreas Kling
Modified: 2014-11-20 00:36 PST (History)
1 user (show)

See Also:

Attachments
Patch (8.87 KB, patch)
2014-11-19 21:11 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (8.96 KB, patch)
2014-11-19 22:52 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-19 21:11:23 PST 
Patch forthcoming.
Comment 1 Andreas Kling 2014-11-19 21:11:49 PST 
Created attachment 241925 [details]
Patch
Comment 2 Chris Dumez 2014-11-19 21:30:34 PST 
Comment on attachment 241925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241925&action=review

> Source/WebCore/editing/FrameSelection.cpp:1361
> +    if (RenderBlock* caretPainter = rendererForCaretPainting(node))

auto* ?

> Source/WebCore/editing/FrameSelection.cpp:1481
> +    if (RenderBlock* renderer = rendererForCaretPainting(node))

auto* ?

> Source/WebCore/editing/htmlediting.cpp:1276
>      bool paintedByBlock = renderer->isRenderBlockFlow() && caretRendersInsideNode(node);

is<RenderBlockFlow>(*renderer) ?
Comment 3 Andreas Kling 2014-11-19 22:52:02 PST 
Created attachment 241927 [details]
Patch

Tweak Chris's tweaks.
Comment 4 Chris Dumez 2014-11-19 22:57:26 PST 
Comment on attachment 241927 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2014-11-20 00:36:07 PST 
Comment on attachment 241927 [details]
Patch

Clearing flags on attachment: 241927

Committed r176387: <http://trac.webkit.org/changeset/176387>
Comment 6 WebKit Commit Bot 2014-11-20 00:36:11 PST 
All reviewed patches have been landed.  Closing bug.