Bug 138985 - RenderElement::removeChild() doesn't need a return value.
Summary: RenderElement::removeChild() doesn't need a return value.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-21 15:14 PST by Andreas Kling
Modified: 2014-11-21 15:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (34.72 KB, patch)
2014-11-21 15:14 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-21 15:14:00 PST 
It looks like nobody uses the return value from RenderElement::removeChild().
Instead of plumbing it through everywhere, we should just remove it.
((Maybe someday, removeChild() could return a smart pointer that owns the renderer that got removed.))
Comment 1 Andreas Kling 2014-11-21 15:14:30 PST 
Created attachment 242076 [details]
Patch
Comment 2 Andreas Kling 2014-11-21 15:40:29 PST 
http://trac.webkit.org/changeset/176478