Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky (fails sometimes) since it was added in r176479 <http://trac.webkit.org/r176479> When it fails, the diff is: --- /home/clopez/webkit/webkit/layout-test-results/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt +++ /home/clopez/webkit/webkit/layout-test-results/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-actual.txt @@ -13,8 +13,8 @@ Response value is 12 Evaluating in DFG frame at frame[2]: 'localVal3' Response value is 12 -Resumed from breakpoint inside breakpointBasic result: 42 +Resumed from breakpoint Test complete https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r176918%20%284672%29/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-pretty-diff.html
Marked accordingly on the GTK expectations on https://trac.webkit.org/r176922
Created attachment 380683 [details] Patch
Comment on attachment 380683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380683&action=review rs=me, but please run it through EWS one more time since it looks like there were some (possibly unrelated) failures on mac-debug-wk1 > LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:99 > + setTimeout(function (responseObject) { What about this? ``` InspectorProtocol.awaitEvent({event: "Debugger.resumed"}).then(() => { ProtocolTest.log("Resumed from breakpoint"); ProtocolTest.log("Test complete"); ProtocolTest.completeTest(); }); InspectorProtocol.sendCommand("Debugger.resume"); ```
Comment on attachment 380683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380683&action=review >> LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:99 >> + setTimeout(function (responseObject) { > > What about this? > ``` > InspectorProtocol.awaitEvent({event: "Debugger.resumed"}).then(() => { > ProtocolTest.log("Resumed from breakpoint"); > ProtocolTest.log("Test complete"); > ProtocolTest.completeTest(); > }); > InspectorProtocol.sendCommand("Debugger.resume"); > ``` Yes, this will work, because Debugger.resumed is sent after exiting from the nested loop. Updated the test.
Created attachment 381997 [details] Patch for landing
Created attachment 381998 [details] Patch for landing
Comment on attachment 381998 [details] Patch for landing Clearing flags on attachment: 381998 Committed r251628: <https://trac.webkit.org/changeset/251628>
All reviewed patches have been landed. Closing bug.