Bug 139364 - [GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg.html crashes.
Summary: [GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg.html crashes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-07 07:30 PST by Carlos Alberto Lopez Perez
Modified: 2023-01-25 19:32 PST (History)
2 users (show)

See Also:


Attachments
GDB Backtrace for the GTK port when running the test inspector-protocol/debugger/setBreakpoint-dfg.html on r176918 (24.63 KB, text/plain)
2014-12-07 07:30 PST, Carlos Alberto Lopez Perez
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-12-07 07:30:33 PST
Created attachment 242742 [details]
GDB Backtrace for the GTK port when running the test inspector-protocol/debugger/setBreakpoint-dfg.html on r176918

Since r[176459-176503] (I was not able to identify the specific commit, only that range) the layout test inspector-protocol/debugger/setBreakpoint-dfg.html crashes on platform GTK.

The same seems to happen for platforms EFL and AppleWin

Before that it was flaky. Check 128736.

I'm attaching a GDB backtrace for port GTK on r176918
Comment 1 Carlos Alberto Lopez Perez 2014-12-07 08:07:48 PST
Maybe (just guessing, didn't tested) the revision causing the regression was r176479 (is inside the range) and it caused another regressions on the inspector. Check bug 139359.
Comment 2 Carlos Alberto Lopez Perez 2014-12-07 08:15:38 PST
Marked accordingly on the GTK expectations on https://trac.webkit.org/r176922
Comment 3 Marcos Chavarría Teijeiro (irc: chavaone) 2015-04-17 03:28:42 PDT
The test is flaky since r179015 (http://trac.webkit.org/changeset/179015).

When it fails the diff is the following:

--- /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/inspector-protocol/debugger/setBreakpoint-dfg-expected.txt
+++ /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/inspector-protocol/debugger/setBreakpoint-dfg-actual.txt
@@ -1,18 +1,2 @@
-Debugger.setBreakpoint in DFG compiled functions.
+FAIL: Timed out waiting for notifyDone to be called

-Found breakpoint.js
-dfgWithoutInline result: 502500
-dfgWithInline result: 504500
-dfg functions warmed up
-
-Breakpoint set in notInlineable()
-Breakpoint set in inlineable()
-
-Hit Breakpoint 1!
-Removed Breakpoint 1!
-dfgWithoutInline result: 502500
-Hit Breakpoint 2!
-Removed Breakpoint 2!
-dfgWithInline result: 504500
-PASS
-

Updating test expectations on bug 143870.
Comment 4 Diego Pino 2023-01-25 19:32:38 PST
There are no references to this bug in any TestExpectations. It's probable this bug was solved at some point but it wasn't marked as closed. I'm closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations.