Bug 139883 - [Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline-tables-only
Summary: [Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-22 16:33 PST by Mark Rowe (bdash)
Modified: 2014-12-22 18:24 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2014-12-22 16:37 PST, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-12-22 16:33:51 PST 
The logic I added in r177254 was incorrect with regards to the precedence of conditional build settings vs unconditional ones. This has resulted in engineering builds of WebCore on OS X 10.8 and 10.9 being incorrectly built with -gline-tables-only.

<rdar://problem/19297261>
Comment 1 Mark Rowe (bdash) 2014-12-22 16:37:37 PST 
Created attachment 243647 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-12-22 17:31:57 PST 
Comment on attachment 243647 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2014-12-22 18:24:28 PST 
Comment on attachment 243647 [details]
Patch

Clearing flags on attachment: 243647

Committed r177674: <http://trac.webkit.org/changeset/177674>
Comment 4 WebKit Commit Bot 2014-12-22 18:24:31 PST 
All reviewed patches have been landed.  Closing bug.