RESOLVED FIXED 139947
DOM exception creator functions should return Ref. 
https://bugs.webkit.org/show_bug.cgi?id=139947
Summary DOM exception creator functions should return Ref.
Andreas Kling
Reported 2014-12-25 16:32:04 PST
Yep.
Attachments
Patch (19.09 KB, patch)
2014-12-25 16:52 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-12-25 16:52:03 PST
Created attachment 243750 [details] Patch
Chris Dumez
Comment 2 2014-12-25 19:33:28 PST
Comment on attachment 243750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243750&action=review r=me with one suggestion. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1174 > + push(@headerContent, "inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, $implType& impl) { return toJS(exec, globalObject, &impl); }\n"); Would be nice to do the opposite (have the one taking a pointer calling the one taking a ref, after doing the null-check). This way, we'll do less null checks thanks to Ref<>.
Andreas Kling
Comment 3 2014-12-25 20:22:06 PST
(In reply to comment #2) > Comment on attachment 243750 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243750&action=review > > r=me with one suggestion. > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1174 > > + push(@headerContent, "inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, $implType& impl) { return toJS(exec, globalObject, &impl); }\n"); > > Would be nice to do the opposite (have the one taking a pointer calling the > one taking a ref, after doing the null-check). This way, we'll do less null > checks thanks to Ref<>. Good idea! I'll do that separately.
Andreas Kling
Comment 4 2014-12-25 20:23:33 PST
Comment on attachment 243750 [details] Patch Clearing flags on attachment: 243750 Committed r177744: <http://trac.webkit.org/changeset/177744>
Andreas Kling
Comment 5 2014-12-25 20:23:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.