Bug 140109 - Pack WebCore::RuleData better.
Summary: Pack WebCore::RuleData better.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 140159
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-05 18:05 PST by Andreas Kling
Modified: 2015-01-06 17:39 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2015-01-05 18:06 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-05 18:05:45 PST 
We can save some memory by packing the members of RuleData better.
Comment 1 Andreas Kling 2015-01-05 18:06:25 PST 
Created attachment 244026 [details]
Patch
Comment 2 Benjamin Poulain 2015-01-05 18:09:12 PST 
Comment on attachment 244026 [details]
Patch

It would be good to have a static_assert checking RuleData does not grow.
Comment 3 WebKit Commit Bot 2015-01-06 13:20:40 PST 
Comment on attachment 244026 [details]
Patch

Clearing flags on attachment: 244026

Committed r177988: <http://trac.webkit.org/changeset/177988>
Comment 4 WebKit Commit Bot 2015-01-06 13:20:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2015-01-06 17:39:11 PST 
Re-opened since this is blocked by bug 140159