Bug 140369 - Geolocation objects shouldn't prevent page caching.
Summary: Geolocation objects shouldn't prevent page caching.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-12 12:50 PST by Andreas Kling
Modified: 2015-01-12 15:14 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.18 KB, patch)
2015-01-12 12:53 PST, Andreas Kling 		joepeck: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mountainlion (513.70 KB, application/zip)
2015-01-12 13:41 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mountainlion-wk2 (519.85 KB, application/zip)
2015-01-12 13:44 PST, Build Bot 		no flags Details
Patch for landing (19.04 KB, patch)
2015-01-12 14:26 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-12 12:50:37 PST 
We already have code for suspending/resuming Geolocation objects on iOS, but I see no reason we can't share it with other platforms.
Comment 1 Andreas Kling 2015-01-12 12:53:39 PST 
Created attachment 244458 [details]
Patch
Comment 2 Joseph Pecoraro 2015-01-12 13:29:15 PST 
Comment on attachment 244458 [details]
Patch

Nice! r=me
Comment 3 Build Bot 2015-01-12 13:41:53 PST 
Comment on attachment 244458 [details]
Patch

Attachment 244458 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6511104075235328

New failing tests:
fast/dom/Geolocation/no-page-cache.html
Comment 4 Build Bot 2015-01-12 13:41:56 PST 
Created attachment 244462 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2015-01-12 13:44:17 PST 
Comment on attachment 244458 [details]
Patch

Attachment 244458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5229146665910272

New failing tests:
fast/dom/Geolocation/no-page-cache.html
Comment 6 Build Bot 2015-01-12 13:44:20 PST 
Created attachment 244463 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Andreas Kling 2015-01-12 14:26:57 PST 
Created attachment 244467 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2015-01-12 15:14:24 PST 
Comment on attachment 244467 [details]
Patch for landing

Clearing flags on attachment: 244467

Committed r178300: <http://trac.webkit.org/changeset/178300>
Comment 9 WebKit Commit Bot 2015-01-12 15:14:30 PST 
All reviewed patches have been landed.  Closing bug.