Bug 140952 - JavaScript bindings constructors should take Ref<ImplType>&&.
Summary: JavaScript bindings constructors should take Ref<ImplType>&&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 12:57 PST by Andreas Kling
Modified: 2015-01-29 17:12 PST (History)
2 users (show)

See Also:

Attachments
Patch (51.94 KB, patch)
2015-01-27 12:58 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-01-27 12:57:07 PST 
When constructing a JS wrapper object, there is always going to be a corresponding DOM object.
Therefore we should pass the DOM object by Ref&& rather than PassRefPtr.
Comment 1 Andreas Kling 2015-01-27 12:58:50 PST 
Created attachment 245462 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-29 11:41:12 PST 
Comment on attachment 245462 [details]
Patch

Clearing flags on attachment: 245462

Committed r179353: <http://trac.webkit.org/changeset/179353>
Comment 3 WebKit Commit Bot 2015-01-29 11:41:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2015-01-29 17:12:33 PST 
Several WebGL tests started to flakily fail around the time of this change. Can it be the culprit?

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2F1.0.2%2Fconformance%2Fglsl%2Ffunctions%2Fglsl-function-cos.html