Bug 141709 - [GTK] Layout Tests for cross-frame http are failing since expectation changed
Summary: [GTK] Layout Tests for cross-frame http are failing since expectation changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-17 09:46 PST by Marcos Chavarría Teijeiro (irc: chavaone)
Modified: 2017-06-08 10:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2015-05-05 02:40 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags Details | Formatted Diff | Diff
Patch (6.00 KB, patch)
2017-06-08 08:19 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-02-17 09:46:47 PST 
The http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html and http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt layout tests are failing since *-expected file spacing was changed on r180202 (https://trac.webkit.org/changeset/180202).

The diff is the following:
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r180216%20%286297%29/http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r180216%20%286297%29/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-pretty-diff.html
Comment 1 Marcos Chavarría Teijeiro (irc: chavaone) 2015-05-05 02:40:05 PDT 
Created attachment 252372 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-06-08 06:21:07 PDT 
I missed this somehow.

Let's see if this passes Mac/iOS EWS and land it.
Comment 3 Carlos Alberto Lopez Perez 2017-06-08 08:19:13 PDT 
Created attachment 312305 [details]
Patch

Patch for landing
Comment 4 WebKit Commit Bot 2017-06-08 10:01:54 PDT 
Comment on attachment 312305 [details]
Patch

Clearing flags on attachment: 312305

Committed r217931: <http://trac.webkit.org/changeset/217931>
Comment 5 WebKit Commit Bot 2017-06-08 10:01:56 PDT 
All reviewed patches have been landed.  Closing bug.