Bug 142090 - Use NeverDestroyed for JS wrapper owners.
Summary: Use NeverDestroyed for JS wrapper owners.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2015-02-27 10:48 PST by Andreas Kling
Modified: 2015-02-27 11:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (16.05 KB, patch)
2015-02-27 10:50 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-02-27 10:48:25 PST 
We should use WTF::NeverDestroyed for all the JSFooOwner classes that we generate. That will prevent them from pinning down large malloc pages long after we've navigated away from the site that instantiated them.
Comment 1 Andreas Kling 2015-02-27 10:50:10 PST 
Created attachment 247522 [details]
Patch
Comment 2 Chris Dumez 2015-02-27 10:52:05 PST 
Comment on attachment 247522 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2015-02-27 11:52:30 PST 
Comment on attachment 247522 [details]
Patch

Clearing flags on attachment: 247522

Committed r180772: <http://trac.webkit.org/changeset/180772>
Comment 4 WebKit Commit Bot 2015-02-27 11:52:35 PST 
All reviewed patches have been landed.  Closing bug.