Bug 142489 - [GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
Summary: [GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-09 05:48 PDT by Marcos Chavarría Teijeiro (irc: chavaone)
Modified: 2021-11-25 04:09 PST (History)
12 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2021-11-24 11:08 PST, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (2.92 KB, patch)
2021-11-24 11:26 PST, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2021-11-25 01:42 PST, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Patch (4.59 KB, patch)
2021-11-25 03:06 PST, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-09 05:48:56 PDT 
The http/tests/media/video-play-waiting.html layout test is timing out since it was added on r179220 (https://trac.webkit.org/changeset/r179220).
Comment 1 Enrique Ocaña 2021-11-24 11:08:33 PST 
Created attachment 445102 [details]
Patch
Comment 2 Philippe Normand 2021-11-24 11:16:15 PST 
Comment on attachment 445102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445102&action=review

> LayoutTests/ChangeLog:16
> +        * http/tests/media/video-play-waiting.html: Set the video src to empty.

this is not flagged in TestExpectations?
Comment 3 Enrique Ocaña 2021-11-24 11:21:35 PST 
Comment on attachment 445102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445102&action=review

>> LayoutTests/ChangeLog:16
>> +        * http/tests/media/video-play-waiting.html: Set the video src to empty.
> 
> this is not flagged in TestExpectations?

I always forget to unflag, sorry. Thanks for catching it!
Comment 4 Enrique Ocaña 2021-11-24 11:26:55 PST 
Created attachment 445103 [details]
Patch
Comment 5 Philippe Normand 2021-11-24 12:59:35 PST 
Comment on attachment 445103 [details]
Patch

Good catch, this indeed times out on all platforms, https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fmedia%2Fvideo-play-waiting.html maybe you can un-flag in the top-level TestExpectatoins too?
Comment 6 Enrique Ocaña 2021-11-25 01:42:56 PST 
Created attachment 445125 [details]
Patch
Comment 7 Enrique Ocaña 2021-11-25 03:06:08 PST 
Created attachment 445129 [details]
Patch
Comment 8 Enrique Ocaña 2021-11-25 03:59:18 PST 
Unskipped on all platforms, but the test fails on Mac for a reason unrelated to this fix, so I marked it as failing there.
Comment 9 EWS 2021-11-25 04:02:35 PST 
Committed r286165 (244548@main): <https://commits.webkit.org/244548@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445129 [details].
Comment 10 Radar WebKit Bug Importer 2021-11-25 04:03:24 PST 
<rdar://problem/85748438>