Bug 142640 - Use std::atomic for CodeBlock::m_visitAggregateHasBeenCalled
Summary: Use std::atomic for CodeBlock::m_visitAggregateHasBeenCalled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 13:43 PDT by Mark Lam
Modified: 2015-03-12 15:15 PDT (History)
7 users (show)

See Also:

Attachments
the patch. (5.15 KB, patch)
2015-03-12 14:03 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-03-12 13:43:56 PDT 
We used to spin our own compare and swap on a uint8_t.  Now that we can use C++11, let's use std::atomic.
Comment 1 Mark Lam 2015-03-12 14:03:45 PDT 
Created attachment 248543 [details]
the patch.
Comment 2 Mark Hahnenberg 2015-03-12 14:23:00 PDT 
Comment on attachment 248543 [details]
the patch.

Seems reasonable to me.
Comment 3 WebKit Commit Bot 2015-03-12 15:15:03 PDT 
Comment on attachment 248543 [details]
the patch.

Clearing flags on attachment: 248543

Committed r181456: <http://trac.webkit.org/changeset/181456>
Comment 4 WebKit Commit Bot 2015-03-12 15:15:07 PDT 
All reviewed patches have been landed.  Closing bug.