Bug 142798 - Refactor execution time limit tests out of testapi.c
Summary: Refactor execution time limit tests out of testapi.c
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-17 15:45 PDT by Mark Lam
Modified: 2015-03-21 10:40 PDT (History)
3 users (show)

See Also:


Attachments
the patch. (33.00 KB, patch)
2015-03-17 15:50 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-03-17 15:45:53 PDT
These tests were sometimes failing to time out on C loop builds.  Let's refactor them out of the big monolith that is testapi.c so that we can reason more easily about them and make adjustments if needed.
Comment 1 Mark Lam 2015-03-17 15:50:31 PDT
Created attachment 248878 [details]
the patch.
Comment 2 Michael Saboff 2015-03-17 16:03:43 PDT
Comment on attachment 248878 [details]
the patch.

rs=me
Comment 3 Mark Lam 2015-03-17 16:07:49 PDT
Thanks.  Landed in r181670: <http://trac.webkit.org/r181670>.
Comment 4 David Kilzer (:ddkilzer) 2015-03-21 10:25:50 PDT
Should the new file be added to JavaScriptCore.vcproj for Windows as well?
Comment 5 Brent Fulgham 2015-03-21 10:40:52 PDT
(In reply to comment #4)
> Should the new file be added to JavaScriptCore.vcproj for Windows as well?

Id ally there should be a Windows implementation of this, but as it stands these are Darwin-only so there's not much point in touching the VS project ere.