Bug 143229 - [GTK] Layout Test accessibility/aria-toggle-button-with-title.html is failing
Summary: [GTK] Layout Test accessibility/aria-toggle-button-with-title.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-30 10:32 PDT by Marcos Chavarría Teijeiro (irc: chavaone)
Modified: 2015-04-13 03:23 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2015-03-30 11:10 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-30 10:32:09 PDT 
The accessibility/aria-toggle-button-with-title.html layout test is failing on GTK+ since r182012 (https://trac.webkit.org/changeset/182012).

This revision updates the way a role=button + aria-pressed object should be exposed as AXCheckbox on Mac.

The diff is the following:

--- /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/accessibility/aria-toggle-button-with-title-expected.txt
+++ /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/accessibility/aria-toggle-button-with-title-actual.txt
@@ -8,7 +8,7 @@
 PASS successfullyParsed is true

 TEST COMPLETE
-Role: AXRole: AXCheckBox
+Role: AXRole: AXToggleButton
 PASS tbutton1.title is 'AXTitle: Toggle button'
 Role: AXRole: AXButton
 PASS button.title is 'AXTitle: Button title'
Comment 1 Radar WebKit Bug Importer 2015-03-30 10:32:33 PDT 
<rdar://problem/20348058>
Comment 2 Radar WebKit Bug Importer 2015-03-30 10:33:23 PDT 
<rdar://problem/20348078>
Comment 3 chris fleizach 2015-03-30 11:02:11 PDT 
Can you post the whole new actual file that you get. i can post that as the new expected results for GTK
Comment 4 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-30 11:10:18 PDT 
Created attachment 249747 [details]
Patch
Comment 5 chris fleizach 2015-03-30 11:11:04 PDT 
Comment on attachment 249747 [details]
Patch

i think this may fail because you've put unreviewed in there, lets' see
Comment 6 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-30 11:13:56 PDT 
(In reply to comment #5)
> Comment on attachment 249747 [details]
> Patch
> 
> i think this may fail because you've put unreviewed in there, lets' see

The thing is that being a gardening patch it doesn't need revision but I forget to add the --no-review flag when I call to upload the patch. Thanks! :)
Comment 7 WebKit Commit Bot 2015-03-30 11:59:11 PDT 
Comment on attachment 249747 [details]
Patch

Clearing flags on attachment: 249747

Committed r182149: <http://trac.webkit.org/changeset/182149>
Comment 8 WebKit Commit Bot 2015-03-30 11:59:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Csaba Osztrogonác 2015-04-13 03:23:12 PDT 
EFL had similar difference - fixed in http://trac.webkit.org/changeset/182699