Bug 144616 - Record the reference time when Performance is constructed.
Summary: Record the reference time when Performance is constructed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: BlinkMergeCandidate, InRadar, Performance
Depends on:
Blocks:
 
Reported: 2015-05-04 18:26 PDT by Andreas Kling
Modified: 2015-05-05 09:20 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (2.75 KB, patch)
2015-05-04 18:45 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-04 18:26:53 PDT 
<rdar://problem/20249480>

Blink does this nice thing where they copy the current time into a member of Performance when it's constructed.
Performance::now() can then just compare against that member.
Comment 1 Andreas Kling 2015-05-04 18:28:42 PDT 
https://chromium.googlesource.com/chromium/blink.git/+/bea17fc8cb735eaf07bc68e211ba2f30a9298a47

Record the reference time when Performance is constructed.

BUG=264490

Review URL: https://chromiumcodereview.appspot.com/23367007

(by simonjam@)
Comment 2 Andreas Kling 2015-05-04 18:45:23 PDT 
Created attachment 252362 [details]
Proposed patch
Comment 3 Geoffrey Garen 2015-05-04 19:17:32 PDT 
Comment on attachment 252362 [details]
Proposed patch

r=me
Comment 4 WebKit Commit Bot 2015-05-04 21:50:21 PDT 
Comment on attachment 252362 [details]
Proposed patch

Clearing flags on attachment: 252362

Committed r183795: <http://trac.webkit.org/changeset/183795>
Comment 5 WebKit Commit Bot 2015-05-04 21:50:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Andreas Kling 2015-05-05 09:20:53 PDT 
(In reply to comment #6)
> This broke a test:
> https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/
> r183803%20(4053)/results.html

Patched up the bots in http://trac.webkit.org/changeset/183808
Thanks for the beep, Simon.