Bug 144874 - PropertyNameArray should use a Vector when there are few entries.
Summary: PropertyNameArray should use a Vector when there are few entries.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2015-05-11 10:56 PDT by Andreas Kling
Modified: 2015-05-11 14:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2015-05-11 10:57 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-11 10:56:31 PDT
PropertyNameArray used to switch between Vector and HashMap backing store. It was lost in the for-in refactoring. We can bring it back for a speedup.
Comment 1 Andreas Kling 2015-05-11 10:57:45 PDT
Created attachment 252866 [details]
Patch
Comment 2 Geoffrey Garen 2015-05-11 13:00:08 PDT
Comment on attachment 252866 [details]
Patch

r=me
Comment 3 Andreas Kling 2015-05-11 14:15:18 PDT
Comment on attachment 252866 [details]
Patch

Clearing flags on attachment: 252866

Committed r184120: <http://trac.webkit.org/changeset/184120>
Comment 4 Andreas Kling 2015-05-11 14:15:22 PDT
All reviewed patches have been landed.  Closing bug.