Bug 145213 - Eden collections should extend the IncrementalSweeper work list, not replace it.
Summary: Eden collections should extend the IncrementalSweeper work list, not replace it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2015-05-20 10:46 PDT by Andreas Kling
Modified: 2015-05-20 13:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.53 KB, patch)
2015-05-20 11:00 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2015-05-20 11:07 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-20 10:46:17 PDT
<rdar://problem/21002666>
Comment 1 Andreas Kling 2015-05-20 11:00:43 PDT
Created attachment 253447 [details]
Patch
Comment 2 Andreas Kling 2015-05-20 11:07:20 PDT
Created attachment 253449 [details]
Patch
Comment 3 Geoffrey Garen 2015-05-20 11:13:42 PDT
Comment on attachment 253449 [details]
Patch

r=me
Comment 4 Geoffrey Garen 2015-05-20 11:22:38 PDT
It's strange that a bug in the incremental sweeper could cause runaway memory use. By design, each new object allocated should sweep an old object freed. The incremental sweeper is supposed to be an optimization, not an essential way to avoid runaway memory use.
Comment 5 WebKit Commit Bot 2015-05-20 13:30:51 PDT
Comment on attachment 253449 [details]
Patch

Clearing flags on attachment: 253449

Committed r184652: <http://trac.webkit.org/changeset/184652>
Comment 6 WebKit Commit Bot 2015-05-20 13:30:54 PDT
All reviewed patches have been landed.  Closing bug.