Bug 145224 - Remove unused MarkedBlock::m_rememberedSet.
Summary: Remove unused MarkedBlock::m_rememberedSet.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2015-05-20 14:58 PDT by Andreas Kling
Modified: 2022-02-27 23:37 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.16 KB, patch)
2015-05-20 15:05 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (6.76 KB, patch)
2015-05-20 15:13 PDT, Andreas Kling
mhahnenb: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-20 14:58:12 PDT
The remembered bit is stored in the JSCell, and that's where everyone looks for it.
We were keeping an atomic bitmap up-to-date in the MarkedBlock for no reason.
Comment 1 Andreas Kling 2015-05-20 15:05:45 PDT
Created attachment 253463 [details]
Patch
Comment 2 Andreas Kling 2015-05-20 15:13:06 PDT
Created attachment 253464 [details]
Patch
Comment 3 Mark Hahnenberg 2015-05-20 15:20:11 PDT
Comment on attachment 253464 [details]
Patch

Whoops :-) r=me
Comment 4 Andreas Kling 2015-05-20 15:26:15 PDT
Landed in <https://trac.webkit.org/r184666>