Bug 145400 - <font face> doesn't support plus character in font family names.
Summary: <font face> doesn't support plus character in font family names.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-26 19:43 PDT by Andreas Kling
Modified: 2015-05-26 21:14 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (8.37 KB, patch)
2015-05-26 19:46 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-26 19:43:45 PDT 
<rdar://problem/21097484>

<font face> attributes should support font names such as "Myles + Darin"
Comment 1 Andreas Kling 2015-05-26 19:46:16 PDT 
Created attachment 253773 [details]
Proposed patch
Comment 2 Darin Adler 2015-05-26 19:52:44 PDT 
Comment on attachment 253773 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253773&action=review

> Source/WebCore/css/CSSParser.cpp:1297
> +        for (auto propertyID : { CSSValueSerif, CSSValueSansSerif, CSSValueCursive, CSSValueFantasy, CSSValueMonospace, CSSValueWebkitBody }) {

Somehow I feel that every single call site that has this list of special family names should have some kind of FIXME in it. This joins a large and seemingly growing family.
Comment 3 WebKit Commit Bot 2015-05-26 21:14:10 PDT 
Comment on attachment 253773 [details]
Proposed patch

Clearing flags on attachment: 253773

Committed r184894: <http://trac.webkit.org/changeset/184894>
Comment 4 WebKit Commit Bot 2015-05-26 21:14:15 PDT 
All reviewed patches have been landed.  Closing bug.