Bug 145443 - GraphicsLayerCA should start out with m_intersectsCoverageRect=false
Summary: GraphicsLayerCA should start out with m_intersectsCoverageRect=false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2015-05-28 13:53 PDT by Andreas Kling
Modified: 2015-05-28 16:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch idea (3.44 KB, patch)
2015-05-28 14:00 PDT, Andreas Kling 		simon.fraser: review-
Details | Formatted Diff | Diff
Smaller patch with a test! (7.69 KB, patch)
2015-05-28 16:03 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-28 13:53:22 PDT 
<rdar://problem/19685798>

Currently GraphicsLayerCA::setVisibleAndCoverageRects() will return early if neither the visible or coverage rects have changed.
This may cause us to not update m_intersectsCoverageRect if the layer's own rect has changed.
Comment 1 Andreas Kling 2015-05-28 14:00:23 PDT 
Created attachment 253861 [details]
Patch idea
Comment 2 Simon Fraser (smfr) 2015-05-28 14:44:50 PDT 
Comment on attachment 253861 [details]
Patch idea

Andreas and I talked about this, and he's going to look at an alternate solution, and a test case.
Comment 3 Andreas Kling 2015-05-28 16:03:28 PDT 
Created attachment 253873 [details]
Smaller patch with a test!
Comment 4 Andreas Kling 2015-05-28 16:48:47 PDT 
Comment on attachment 253873 [details]
Smaller patch with a test!

Clearing flags on attachment: 253873

Committed r184968: <http://trac.webkit.org/changeset/184968>
Comment 5 Andreas Kling 2015-05-28 16:48:50 PDT 
All reviewed patches have been landed.  Closing bug.