Bug 145689 - FunctionExecutable::isCompiling() is weird and wrong.
Summary: FunctionExecutable::isCompiling() is weird and wrong.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-05 00:42 PDT by Andreas Kling
Modified: 2015-06-09 14:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2015-06-05 00:50 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-06-05 00:42:14 PDT 
FunctionExecutable::isCompiling() will effectively always return false.
It was probably correct back in the day when there was only the interpreter and the baseline JIT.
Comment 1 Andreas Kling 2015-06-05 00:50:50 PDT 
Created attachment 254345 [details]
Patch
Comment 2 Geoffrey Garen 2015-06-05 10:15:27 PDT 
Comment on attachment 254345 [details]
Patch

r=me
Comment 3 Andreas Kling 2015-06-09 14:20:37 PDT 
Comment on attachment 254345 [details]
Patch

Clearing flags on attachment: 254345

Committed r185379: <http://trac.webkit.org/changeset/185379>
Comment 4 Andreas Kling 2015-06-09 14:20:40 PDT 
All reviewed patches have been landed.  Closing bug.