Bug 145786 - [JSC] Polymorphic{Get,Put}ByIdList::addAccess() should optimize for size, not speed.
Summary: [JSC] Polymorphic{Get,Put}ByIdList::addAccess() should optimize for size, not...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2015-06-08 22:18 PDT by Andreas Kling
Modified: 2015-06-09 14:23 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2015-06-08 22:19 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-06-08 22:18:48 PDT
These functions clearly want Vector::resizeToFit(), not resize().
Comment 1 Andreas Kling 2015-06-08 22:19:41 PDT
Created attachment 254548 [details]
Patch
Comment 2 Andreas Kling 2015-06-09 14:23:33 PDT
Comment on attachment 254548 [details]
Patch

Clearing flags on attachment: 254548

Committed r185381: <http://trac.webkit.org/changeset/185381>
Comment 3 Andreas Kling 2015-06-09 14:23:35 PDT
All reviewed patches have been landed.  Closing bug.