Bug 146679 - REGRESSION(r183706): HTMLImageElement sometimes fails to register as document named item.
Summary: REGRESSION(r183706): HTMLImageElement sometimes fails to register as document...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2015-07-07 01:33 PDT by Andreas Kling
Modified: 2015-07-07 08:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.92 KB, patch)
2015-07-07 01:39 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (5.99 KB, patch)
2015-07-07 01:53 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-07-07 01:33:30 PDT 
<rdar://problem/21613839>
Comment 1 Andreas Kling 2015-07-07 01:39:29 PDT 
Created attachment 256292 [details]
Patch
Comment 2 Antti Koivisto 2015-07-07 01:47:54 PDT 
Comment on attachment 256292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256292&action=review

> Source/WebCore/html/HTMLImageElement.h:135
> +    bool m_hadName { false }; // FIXME: We only need this because parseAttribute() can't see the old value.

This is bit misleading since most of the time it is really m_hasName.
Comment 3 Andreas Kling 2015-07-07 01:53:16 PDT 
Created attachment 256293 [details]
Patch for landing
Comment 4 Andreas Kling 2015-07-07 08:55:22 PDT 
Comment on attachment 256293 [details]
Patch for landing

Clearing flags on attachment: 256293

Committed r186461: <http://trac.webkit.org/changeset/186461>
Comment 5 Andreas Kling 2015-07-07 08:55:26 PDT 
All reviewed patches have been landed.  Closing bug.