Now that we're caching more pages with media elements, we need to make some improvements to the suspend/resume behavior: 1) Scheduled events should be suspended, not canceled altogether. 2) <source> elements should suspend their error event delivery. 3) When in page cache, network buffering should be turned off. <rdar://problem/21712311>
Created attachment 256936 [details] Patch for EWS This patch implements the functionality, but will need tests. Letting EWS have a chew.
Thought for posterity: Maybe it would be neat to have event queues that automatically respond to page cache suspend/resume without the owner having to worry about it.
Comment on attachment 256936 [details] Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=256936&action=review > Source/WebCore/html/HTMLSourceElement.cpp:119 > +void HTMLSourceElement::suspendErrorEventDispatch() Maybe we should just mark HTMLSourceElement as an ActiveDOMObject and have it implement suspend() / resume(). Instead of having HTMLMediaElement worry about the source elements when suspending.
Created attachment 256985 [details] Patch for EWS Again for EWS with HTMLSourceElement now inheriting from ActiveDOMObject.
Created attachment 257065 [details] Proposed patch
Comment on attachment 257065 [details] Proposed patch nice, r=me.
Comment on attachment 257065 [details] Proposed patch Clearing flags on attachment: 257065 Committed r187031: <http://trac.webkit.org/changeset/187031>
All reviewed patches have been landed. Closing bug.
This broke layout test media/restore-from-page-cache.html for GTK, see bug #158914. Sorry it took a year to be noticed.