Bug 148492 - Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel
Summary: Web Inspector: agents should send messages through FrontendRouter instead of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on: 148538
Blocks: InspectorHydra
  Show dependency tree / graph
 
Reported: 2015-08-26 14:38 PDT by BJ Burg
Modified: 2015-09-07 18:57 PDT (History)
9 users (show)

See Also:

Attachments
Proposed Fix (95.62 KB, patch)
2015-08-29 09:23 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
For EWS (95.27 KB, patch)
2015-09-04 16:27 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
For EWS (ios, win) (97.16 KB, patch)
2015-09-04 16:54 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
For EWS (win) (97.43 KB, patch)
2015-09-04 17:18 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
For EWS (win) (97.38 KB, patch)
2015-09-04 21:32 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-08-26 14:38:53 PDT 
We shouldn't pass around FrontendChannel*, the FrontendRouter should decide which actual channels to use based on the message type.
Comment 1 Radar WebKit Bug Importer 2015-08-26 14:39:11 PDT 
<rdar://problem/22444749>
Comment 2 BJ Burg 2015-08-29 09:23:50 PDT 
Created attachment 260224 [details]
Proposed Fix

Depends on blocking bug, so it's won't apply yet.
Comment 3 Joseph Pecoraro 2015-09-02 19:04:11 PDT 
Comment on attachment 260224 [details]
Proposed Fix

r=me, but you will likely have to address build issues in other ports, so be aware!
Comment 4 BJ Burg 2015-09-04 16:27:50 PDT 
Created attachment 260646 [details]
For EWS
Comment 5 WebKit Commit Bot 2015-09-04 16:29:54 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 6 BJ Burg 2015-09-04 16:54:42 PDT 
Created attachment 260652 [details]
For EWS (ios, win)
Comment 7 BJ Burg 2015-09-04 17:18:54 PDT 
Created attachment 260654 [details]
For EWS (win)
Comment 8 BJ Burg 2015-09-04 21:32:49 PDT 
Created attachment 260674 [details]
For EWS (win)
Comment 9 BJ Burg 2015-09-05 09:06:31 PDT 
Committed r189433: <http://trac.webkit.org/changeset/189433>
Comment 10 Alex Christensen 2015-09-07 18:57:15 PDT 
My WinCairo bot doesn't like this :(  Could you take a look?
https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/49022/steps/compile-webkit/logs/stdio