RESOLVED FIXED 149803
Remove unused HistoryItem::parent 
https://bugs.webkit.org/show_bug.cgi?id=149803
Summary Remove unused HistoryItem::parent
Andreas Kling
Reported Monday, October 5, 2015 2:04:16 PM UTC
The HistoryItem::m_parent field appears to be unused, so let's try and remove it.
Attachments
Patch (8.17 KB, patch)
2015-10-05 06:17 PDT, Andreas Kling 		andersca: review+
DetailsFormatted DiffDiff
Patch for landing (8.09 KB, patch)
2015-10-05 06:46 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 Monday, October 5, 2015 2:17:52 PM UTC
Created attachment 262429 [details] Patch
Andreas Kling
Comment 2 Monday, October 5, 2015 2:19:59 PM UTC
Comment on attachment 262429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262429&action=review > Source/WebCore/history/HistoryItem.h:213 > - WEBCORE_EXPORT HistoryItem(const URL&, const String& frameName, const String& parent, const String& title); > + WEBCORE_EXPORT HistoryItem(const URL&, const String& frameName, const String& title); Oops, this should be removed as well.
Andreas Kling
Comment 3 Monday, October 5, 2015 2:46:48 PM UTC
Created attachment 262431 [details] Patch for landing
WebKit Commit Bot
Comment 4 Monday, October 5, 2015 3:39:20 PM UTC
Comment on attachment 262431 [details] Patch for landing Clearing flags on attachment: 262431 Committed r190559: <http://trac.webkit.org/changeset/190559>
WebKit Commit Bot
Comment 5 Monday, October 5, 2015 3:39:24 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.