I'm putting together a debug HUD overlay that reports information about memory and CPU usage in the web process.
Created attachment 264151 [details] Draft for EWS
Created attachment 264152 [details] Screen shot of draft patch in action
Created attachment 264165 [details] Draft for EWS Oh, rebased on ToT.
Attachment 264165 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:62: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:46: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:147: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:160: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:167: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:320: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:355: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:457: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:492: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 13 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264165 [details] Draft for EWS Attachment 264165 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/346010 Number of test failures exceeded the failure limit.
Created attachment 264170 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 264183 [details] Draft for EWS
Attachment 264183 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:62: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:46: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:148: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:323: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:358: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:460: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:495: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 13 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264186 [details] Draft for EWS
Attachment 264186 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:46: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:148: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:323: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:358: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:460: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:495: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 12 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264186 [details] Draft for EWS Attachment 264186 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/346534 Number of test failures exceeded the failure limit.
Created attachment 264188 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 264186 [details] Draft for EWS Attachment 264186 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/346542 Number of test failures exceeded the failure limit.
Created attachment 264190 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264186 [details] Draft for EWS Attachment 264186 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/346611 Number of test failures exceeded the failure limit.
Created attachment 264191 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 264241 [details] Draft for EWS Now with WebCore::Settings and WK2 SPI preferences hookups. Layout tests hopefully working again.
Attachment 264241 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:43: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:49: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:151: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:154: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:326: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:361: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:463: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:498: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 13 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264426 [details] Patch
Attachment 264426 [details] did not pass style-queue: ERROR: Source/WebCore/page/ResourceUsageOverlay.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/PlatformMac.cmake:272: Alphabetical sorting problem. "page/cocoa/ResourceUsageOverlayCocoa.mm" should be before "page/cocoa/UserAgent.mm". [list/order] [5] Total errors found: 2 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264426 [details] Patch Clearing flags on attachment: 264426 Committed r191849: <http://trac.webkit.org/changeset/191849>
All reviewed patches have been landed. Closing bug.
Committed r191851: <http://trac.webkit.org/changeset/191851>