* SUMMARY console.profile should use the new Sampling Profiler. * NOTES - Currently it uses the LegacyProfiler. It should work with the new Sampling Profiler. - How that looks is yet to be determined. - Should it enable/disable some set of instruments the frontend has told the backend about? - Should it just start/stop the ScriptProfiler? which will send profiles to the frontend when done. - Should it send sample payload to the frontend on console.profileEnd?
<rdar://problem/24352431>
I have this working now that we've removed the LegacyProfiler. It takes advantage of the frontend informing the backend of the enabled Instruments (which was added for auto record on page navigations). I just need to clean the patches up, test, and justify the policy choices I made.
*** Bug 136466 has been marked as a duplicate of this bug. ***
Created attachment 281294 [details] [PATCH] Proposed Fix Depends on bug 158762.
Created attachment 281316 [details] [PATCH] Proposed Fix
Comment on attachment 281316 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281316&action=review Very clean! > Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp:223 > +} > +void InspectorScriptProfilerAgent::programmaticCaptureStopped() Newline. > Source/WebCore/inspector/InspectorTimelineAgent.cpp:249 > + // Allow duplicate unnamed profiles. Disallow duplicate named profiles. > + if (!title.isEmpty()) { Sad this needs duplicated.
Created attachment 281520 [details] [PATCH] For Landing
Comment on attachment 281520 [details] [PATCH] For Landing Clearing flags on attachment: 281520 Committed r202152: <http://trac.webkit.org/changeset/202152>
The new test is very unstable, timing out very frequently: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2FsetInstruments-programmatic-capture.html Rolling out.
Rolled out in https://trac.webkit.org/r202196
(In reply to comment #9) > The new test is very unstable, timing out very frequently: This appears to be the same issue that affects all inspector tests. Locally, I ran the test, and the directory 400 times in Release and Debug mode without issue. I suggest treating this test the same [ Pass Timeout ] until we have time to investigate the systemic inspector test issue. I filed bug 158948 for these specific timeouts.
<https://trac.webkit.org/changeset/202234> with TestExpectations