Let's do some "MEMBER RESHUFFLING" to save memory here.
Created attachment 270181 [details] Patch for EWS This patch knocks 104 bytes off of CodeBlock (Ha!)
Attachment 270181 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1813: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1818: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1819: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1820: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1821: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
nice. r=me
(In reply to comment #3) > nice. > r=me v.nice let me shuffle the bitfields around a little more and save 8 additional bytes :)
sweet. I'm going to start investigating getting rid of a few fields.
Created attachment 270229 [details] Patch for landing
Attachment 270229 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1814: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1818: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1819: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1820: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1821: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 270229 [details] Patch for landing Clearing flags on attachment: 270229 Committed r195836: <http://trac.webkit.org/changeset/195836>
All reviewed patches have been landed. Closing bug.