Bug 153700 - [GTK] Ruby expansion tests failing
Summary: [GTK] Ruby expansion tests failing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-29 21:30 PST by Michael Catanzaro
Modified: 2016-01-30 12:39 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-01-29 21:30:57 PST 
The following layout tests have been failing on the GTK port since they were marked as cross-platform in r188022:

  fast/ruby/ruby-expansion-cjk-2.html [ ImageOnlyFailure ]
  fast/ruby/ruby-expansion-cjk-3.html [ ImageOnlyFailure ]
  fast/ruby/ruby-expansion-cjk-4.html [ ImageOnlyFailure ]
  fast/ruby/ruby-expansion-cjk-5.html [ ImageOnlyFailure ]
  fast/ruby/ruby-expansion-cjk.html [ ImageOnlyFailure ]

Simon, your commit message says "They may have to be skipped on other platforms." Why would this be more appropriate than marking them as expected failures? I am going to mark them as failures for now.
Comment 1 Carlos Alberto Lopez Perez 2016-01-30 12:39:31 PST 
(In reply to comment #0)
> Simon, your commit message says "They may have to be skipped on other
> platforms." Why would this be more appropriate than marking them as expected
> failures? I am going to mark them as failures for now.

The bot don't runs the test skipped, so it helps to reduce the total time it spends running tests.

If a given test is known to make no sense on a given platform, is best to mark them as skip rather than as failing.